deniskuzZ commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1881971362
##########
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:
##########
@@ -245,16 +245,14 @@ public static void unregisterLoggingContext() {
public static String getLogFilePath() {
String logFilePath = null;
org.apache.logging.log4j.Logger rootLogger = LogManager.getRootLogger();
- if (rootLogger instanceof org.apache.logging.log4j.core.Logger) {
- org.apache.logging.log4j.core.Logger coreLogger =
- (org.apache.logging.log4j.core.Logger)rootLogger;
+ if (rootLogger instanceof org.apache.logging.log4j.core.Logger coreLogger)
{
for (Appender appender : coreLogger.getAppenders().values()) {
- if (appender instanceof FileAppender) {
- logFilePath = ((FileAppender) appender).getFileName();
- } else if (appender instanceof RollingFileAppender) {
- logFilePath = ((RollingFileAppender) appender).getFileName();
- } else if (appender instanceof RollingRandomAccessFileAppender) {
- logFilePath = ((RollingRandomAccessFileAppender)
appender).getFileName();
+ if (appender instanceof FileAppender fileAppender) {
Review Comment:
could extract the snippet into 'getLogFilePath(Appender appender)' and use
switch here?
````
switch (appender) {
case FileAppender fa -> fa.getFileName()
..
}
````
do we need break the looks when condition match?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
