deniskuzZ commented on code in PR #5541:
URL: https://github.com/apache/hive/pull/5541#discussion_r1883896229
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -966,15 +967,10 @@ protected List<Order> getColumnNamesOrder(ASTNode ast)
throws SemanticException
ASTNode child = (ASTNode) ast.getChild(i);
int directionCode =
DirectionUtils.tokenToCode(child.getToken().getType());
child = (ASTNode) child.getChild(0);
- if (child.getToken().getType() != HiveParser.TOK_NULLS_FIRST &&
directionCode == DirectionUtils.ASCENDING_CODE) {
- throw new SemanticException(
- "create/alter bucketed table: not supported NULLS LAST for
SORTED BY in ASC order");
- }
- if (child.getToken().getType() != HiveParser.TOK_NULLS_LAST &&
directionCode == DirectionUtils.DESCENDING_CODE) {
- throw new SemanticException(
- "create/alter bucketed table: not supported NULLS FIRST for
SORTED BY in DESC order");
- }
- colList.add(new
Order(unescapeIdentifier(child.getChild(0).getText()).toLowerCase(),
directionCode));
+ Order order = new
Order(unescapeIdentifier(child.getChild(0).getText()).toLowerCase(),
directionCode);
Review Comment:
why did we remove nullOrder and direction checks? maybe we can drop them for
iceberg, but probably not for the rest of table types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
