dengzhhu653 commented on code in PR #5578:
URL: https://github.com/apache/hive/pull/5578#discussion_r1886109382
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -3019,9 +3036,15 @@ PartitionsResponse
get_partitions_req(1:PartitionsRequest req)
bool delete_partition_column_statistics(1:string db_name, 2:string tbl_name,
3:string part_name, 4:string col_name, 5:string engine) throws
(1:NoSuchObjectException o1, 2:MetaException o2,
3:InvalidObjectException o3,
4:InvalidInputException o4)
+ bool
delete_partition_column_statistics_req(1:DeletePartitionColumnStatisticsRequest
req) throws
+ (1:NoSuchObjectException o1, 2:MetaException o2,
3:InvalidObjectException o3,
+ 4:InvalidInputException o4)
bool delete_table_column_statistics(1:string db_name, 2:string tbl_name,
3:string col_name, 4:string engine) throws
(1:NoSuchObjectException o1, 2:MetaException o2,
3:InvalidObjectException o3,
4:InvalidInputException o4)
+ bool delete_table_column_statistics_req(1:
DeleteTableColumnStatisticsRequest req) throws
Review Comment:
can we merge the two methods? i.e, merge them to `bool
delete_column_statistics_req(DeleteColumnStatisticsRequest req)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
