tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1888097277
##########
ql/pom.xml:
##########
@@ -32,6 +32,10 @@
<!-- dependencies are always listed in sorted order by groupId, artifactId
-->
<!-- intra-project -->
<!-- used for vector code-gen -->
+ <dependency>
+ <groupId>org.openjdk.nashorn</groupId>
Review Comment:
Nashorn Javascript engine was deprecated in jdk11 and was completely removed
from jdk15 onwards.
Nashorn Javascript engine in hive is used for dynamic expression evaluation
especially in partition filtering for temporary tables. it is added as an
explicit dependency to compensate for its removal.
Sources: [https://openjdk.org/jeps/335](https://openjdk.org/jeps/335) ,
[https://openjdk.org/jeps/372](https://openjdk.org/jeps/372)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
