abstractdog commented on code in PR #5598:
URL: https://github.com/apache/hive/pull/5598#discussion_r1906938853


##########
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java:
##########
@@ -678,7 +678,7 @@ public BlockingQueue<UserGroupInformation> call() throws 
Exception {
               ugi.addToken(appToken);
               BlockingQueue<UserGroupInformation> queue = new 
LinkedBlockingQueue<>(numExecutors);
               queue.add(ugi);
-              LOG.debug("Added new ugi pool for " + appTokenIdentifier + ", 
Pool Size: ");
+              LOG.debug("Added new ugi pool for {}. Pool Size:{}", 
appTokenIdentifier, ugiPool.size());

Review Comment:
   nit: space between "Pool Size:" and "{}" to be inline with other message



##########
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java:
##########
@@ -689,7 +689,7 @@ public BlockingQueue<UserGroupInformation> call() throws 
Exception {
         ugi = UserGroupInformation.createRemoteUser(appTokenIdentifier);
         ugi.addToken(appToken);
         queue.offer(ugi);
-        LOG.info("Added new ugi for " + appTokenIdentifier + ". Pool size:" + 
ugiPool.size());
+        LOG.info("Added new ugi pool for {}. Pool Size:{}", 
appTokenIdentifier, ugiPool.size());

Review Comment:
   nit: space between "Pool Size:" and "{}" to be inline with other message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to