okumin commented on code in PR #5595:
URL: https://github.com/apache/hive/pull/5595#discussion_r1912728339
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplicationMigrationTool.java:
##########
@@ -155,6 +155,9 @@ public int run(String[] args) throws Exception {
System.out.println("Completed verification. Source & Target are " +
(failed == 0 ? "in Sync." : "not in Sync."));
System.out.println("Time Taken: " + (System.currentTimeMillis() -
startTime) + " ms");
+ if (failed != 0) {
+ return -1;
+ }
Review Comment:
👍
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplicationMigrationTool.java:
##########
@@ -359,7 +362,6 @@ public boolean validateAtFileLevel(Path srcDir, Path
tgtDir, FileSystem srcFs, F
LocatedFileStatus sourceFile = srcListing.next();
if (filtersPattern != null && !isCopied(sourceFile.getPath(),
filtersPattern)) {
LOG.info("Entry: {} is filtered.", sourceFile.getPath());
- continue;
Review Comment:
I understand this is just a cleanup that doesn't change behaviors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
