DanielZhu58 commented on code in PR #5578:
URL: https://github.com/apache/hive/pull/5578#discussion_r1917618738
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -10330,6 +10330,108 @@ public boolean deletePartitionColumnStatistics(String
catName, String dbName, St
return ret;
}
+ @Override
+ public boolean deletePartitionMultiColumnStatistics(String catName, String
dbName, String tableName,
+ String partName, List<String>
partVals, List<String> colNames, String engine)
+ throws NoSuchObjectException, MetaException, InvalidObjectException,
InvalidInputException {
+ boolean ret = false;
+ Query query = null;
+ dbName = org.apache.commons.lang3.StringUtils.defaultString(dbName,
+ Warehouse.DEFAULT_DATABASE_NAME);
+ catName = normalizeIdentifier(catName);
+ if (tableName == null) {
+ throw new InvalidInputException("Table name is null.");
+ }
+ try {
+ openTransaction();
+ MTable mTable = getMTable(catName, dbName, tableName);
+ MPartitionColumnStatistics mStatsObj;
+ List<MPartitionColumnStatistics> mStatsObjColl;
+ if (mTable == null) {
Review Comment:
I think we can keep this if condition.
Because if mTable is null, the exception will be thrown from here, so we can
know the "Table" does not exist.
If the exception is thrown later with the mPartition, we can know the
"Partition" does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
