dengzhhu653 commented on code in PR #5578:
URL: https://github.com/apache/hive/pull/5578#discussion_r1918057087
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -10234,93 +10234,105 @@ protected Integer getJdoResult(GetHelper<Integer>
ctx) throws MetaException, NoS
public boolean deletePartitionColumnStatistics(String catName, String
dbName, String tableName,
String partName, List<String> partVals, String colName, String engine)
throws NoSuchObjectException, MetaException, InvalidObjectException,
InvalidInputException {
+ List<String> colNames = new ArrayList<>();
+ if (colName != null) {
+ colNames.add(colName);
+ }
+ return deletePartitionMultiColumnStatistics(catName, dbName, tableName,
partName, partVals, colNames, engine);
Review Comment:
The direct sql path is missing, we'd better pushing the `colNames` into the
direct sql, example:
directSql.deletePartitionColumnStats(catName, dbName, tableName, partName,
colNames, engine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
