abstractdog commented on code in PR #5613: URL: https://github.com/apache/hive/pull/5613#discussion_r1923518380
########## ql/src/java/org/apache/hadoop/hive/ql/Compiler.java: ########## @@ -224,6 +224,7 @@ private BaseSemanticAnalyzer analyze() throws Exception { sem.analyze(tree, context); } finally { sem.endAnalysis(); + driverContext.setQueryType(sem, tree); Review Comment: the service works for failed queries too, where e.g. SematicException happened, that's where the finally block kicks in, making the service able to catch the exception as the failure_reason and provide it in the query history record -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org