zratkai commented on code in PR #5498:
URL: https://github.com/apache/hive/pull/5498#discussion_r1928899846
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -165,6 +165,41 @@ static Table getTable(Configuration configuration,
Properties properties) {
return getTable(configuration, properties, false);
}
+ static Snapshot getTableSnapshot(Table table,
org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
Review Comment:
There is already a method in this class with the same name, same input
types, but reverse order:
public static Snapshot
getTableSnapshot(org.apache.hadoop.hive.ql.metadata.Table hmsTable, Table table)
It is confusing, and hard to understand what is the difference. Please use
the same order of parameters, as the old one, and add other name which
expresses the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
