deniskuzZ commented on code in PR #5498:
URL: https://github.com/apache/hive/pull/5498#discussion_r1929707499
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -183,7 +184,11 @@ public static boolean dropTable(Configuration conf,
Properties props) {
* @return true if the Catalog is HiveCatalog
*/
public static boolean hiveCatalog(Configuration conf, Properties props) {
- String catalogName = props.getProperty(InputFormatConfig.CATALOG_NAME);
+ return hiveCatalog(conf, props::getProperty);
+ }
+
+ public static boolean hiveCatalog(Configuration conf, UnaryOperator<String>
props) {
Review Comment:
few failed, I've fixed them and removed this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
