Aggarwal-Raghav commented on code in PR #5616: URL: https://github.com/apache/hive/pull/5616#discussion_r1929812590
########## ql/src/java/org/apache/hadoop/hive/ql/ddl/database/create/CreateDatabaseAnalyzer.java: ########## @@ -113,6 +114,7 @@ public void analyzeInternal(ASTNode root) throws SemanticException { database.setType(DatabaseType.REMOTE); database.setRemote_dbname(remoteDbName); } + database.setOwnerName(SessionState.getUserFromAuthenticator()); Review Comment: Thanks @okumin, for the review and a vaild question but I think there is no need to set owner type. My reasoning is, why set additional info which is not getting utilized by Ranger and post authorization the code flow will enter the CreateDatabaseOperation and there ownerType and other attributes of class will be set. We only need owner name info as it is used by ranger, it doesn't require owner type. In future if Ranger requires ownerType info then we can address it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org