deniskuzZ commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1930421202
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -838,6 +845,9 @@ public void storageHandlerCommit(Properties
commitProperties, Operation operatio
}
HiveIcebergOutputCommitter committer = getOutputCommitter();
try {
+ if (context != null) {
+ committer.commitTask(context);
Review Comment:
can't we get `HiveIcebergOutputCommitter` from `TaskAttemptContext context`?
````
OutputCommitter commiter = getOutputCommitter(context.getConfiguration());
committer.commitTask(context);
....
public static OutputCommitter getOutputCommitter(Configuration conf) {
return
(OutputCommitter)ReflectionUtils.newInstance(this.getClass("mapred.output.committer.class",
FileOutputCommitter.class, OutputCommitter.class), conf);
}
````
see `FileOutputFormatContainer# getOutputCommitter(TaskAttemptContext
context)`
or expose `getOutputCommitter()` via `HiveStorageHandler` interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
