abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1931560420
##########
service/src/java/org/apache/hive/service/server/HiveServer2.java:
##########
@@ -325,6 +327,11 @@ public synchronized void init(HiveConf hiveConf) {
scheduledQueryService =
ScheduledQueryExecutionService.startScheduledQueryExecutorService(hiveConf);
}
+ if (hiveConf.getBoolVar(ConfVars.HIVE_QUERY_HISTORY_ENABLED)) {
+ queryHistoryService = new QueryHistoryService(hiveConf,
serviceContext).start();
Review Comment:
sorry, I don't get this, what's your point here?
there is a constructor and a fluent start call, that starts the actual
"running" things inside
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
