deniskuzZ commented on code in PR #5540: URL: https://github.com/apache/hive/pull/5540#discussion_r1932042910
########## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java: ########## @@ -105,6 +107,13 @@ else if (desc.getPartitionSpec() != null) { compactionRequest.setNumberOfBuckets(desc.getNumberOfBuckets()); } + if (desc.getFileSizeThreshold() != null) { + if (!DDLUtils.isIcebergTable(table) || compactionRequest.getType() != CompactionType.MINOR) { + throw new HiveException(ErrorMsg.UNSUPPORTED_COMPACTION_REQUEST_WITH_FILE_SIZE_THRESHOLD); Review Comment: wait, it's not supported by Major compaction? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org