kasakrisz commented on code in PR #5626: URL: https://github.com/apache/hive/pull/5626#discussion_r1937385492
########## ql/src/test/queries/clientpositive/cbo_rp_null_order.q: ########## @@ -0,0 +1,7 @@ +SET hive.cbo.returnpath.hiveop=true; +SET hive.default.nulls.last=false; + +CREATE TABLE t1(key int, value string); + +EXPLAIN CBO SELECT * FROM t1 a INNER JOIN t1 b on a.key = b.key; Review Comment: I think it has an affect only on queries with limit but without order/sort by. However it doesn't matter which n rows do we pick. We can see the null sort order in the RS properties. ``` Reduce Output Operator key expressions: key (type: string) null sort order: z sort order: + ``` The join is only necessary to get the rule `HiveInsertExchange4JoinRule` to add the `HiveSortExchange` operators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org