deniskuzZ commented on code in PR #5622:
URL: https://github.com/apache/hive/pull/5622#discussion_r1938269510
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -388,21 +388,13 @@ public static PartitionData toPartitionData(StructLike
sourceKey, Types.StructTy
Types.StructType targetKeyType) {
PartitionData data = new PartitionData(targetKeyType);
for (int i = 0; i < targetKeyType.fields().size(); i++) {
Review Comment:
could we replace loop with foreach. it seems we don't actually need index,
but a `field`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
