deniskuzZ commented on code in PR #5262:
URL: https://github.com/apache/hive/pull/5262#discussion_r1683432966
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateReduceFunctionsRule.java:
##########
@@ -517,6 +517,12 @@ private RexNode reduceStddev(
rexBuilder.makeCall(
SqlStdOperatorTable.MINUS,
sumArgSquared, avgSumSquaredArg);
+ final RexNode zeroLiteral =
+ rexBuilder.makeExactLiteral(BigDecimal.ZERO);
+ final RexNode correctedDiff = rexBuilder.makeCall(SqlStdOperatorTable.CASE,
+ rexBuilder.makeCall(SqlStdOperatorTable.LESS_THAN, diff,
zeroLiteral),
Review Comment:
@yangjiandan, should we check that it's not just less than zero, but within
defined epsilon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
