abstractdog commented on PR #5613:
URL: https://github.com/apache/hive/pull/5613#issuecomment-2630646919
> @abstractdog, what happens to the in-memory records when HS2 is shut down?
Should we add flush in `ShutdownHookManager.addShutdownHook(...)`
no, I tried it on a cluster (Kubernetes, simply deleted the HS2 pod), and
addShutdownHook was duplicate handling of this thing as HiveServer2.stop()
flawlessly took care of flushing the records:
```
if (queryHistoryService != null) {
try {
LOG.info("Calling QueryHistoryService.close from HiveServer2.stop");
queryHistoryService.stop();
} catch (Exception e) {
LOG.error("Error stopping queryHistoryService", e);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
