okumin commented on code in PR #3288:
URL: https://github.com/apache/hive/pull/3288#discussion_r1939304495
##########
ql/src/test/results/clientpositive/llap/catalog.q.out:
##########
@@ -0,0 +1,113 @@
+PREHOOK: query: SHOW CATALOGS
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS
+POSTHOOK: type: SHOWCATALOGS
+hive
+#### A masked pattern was here ####
+PREHOOK: type: CREATECATALOG
+PREHOOK: Output: catalog:test_cat
+#### A masked pattern was here ####
+POSTHOOK: type: CREATECATALOG
+POSTHOOK: Output: catalog:test_cat
+#### A masked pattern was here ####
+PREHOOK: type: CREATECATALOG
+PREHOOK: Output: catalog:test_cat
+#### A masked pattern was here ####
+POSTHOOK: type: CREATECATALOG
+POSTHOOK: Output: catalog:test_cat
+#### A masked pattern was here ####
+PREHOOK: query: SHOW CATALOGS
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS
+POSTHOOK: type: SHOWCATALOGS
+hive
+test_cat
+PREHOOK: query: DROP CATALOG test_cat
+PREHOOK: type: DROPCATALOG
+PREHOOK: Input: catalog:test_cat
+PREHOOK: Output: catalog:test_cat
+POSTHOOK: query: DROP CATALOG test_cat
+POSTHOOK: type: DROPCATALOG
+POSTHOOK: Input: catalog:test_cat
+POSTHOOK: Output: catalog:test_cat
+PREHOOK: query: SHOW CATALOGS
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS
+POSTHOOK: type: SHOWCATALOGS
+hive
+#### A masked pattern was here ####
+PREHOOK: type: CREATECATALOG
+PREHOOK: Output: catalog:test_cat
+#### A masked pattern was here ####
+POSTHOOK: type: CREATECATALOG
+POSTHOOK: Output: catalog:test_cat
+#### A masked pattern was here ####
+PREHOOK: query: SHOW CATALOGS
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS
+POSTHOOK: type: SHOWCATALOGS
+hive
+test_cat
+PREHOOK: query: DROP CATALOG IF EXISTS test_cat
+PREHOOK: type: DROPCATALOG
+PREHOOK: Input: catalog:test_cat
+PREHOOK: Output: catalog:test_cat
+POSTHOOK: query: DROP CATALOG IF EXISTS test_cat
+POSTHOOK: type: DROPCATALOG
+POSTHOOK: Input: catalog:test_cat
+POSTHOOK: Output: catalog:test_cat
+PREHOOK: query: SHOW CATALOGS
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS
+POSTHOOK: type: SHOWCATALOGS
+hive
+PREHOOK: query: DROP CATALOG IF EXISTS test_cat
+PREHOOK: type: DROPCATALOG
+POSTHOOK: query: DROP CATALOG IF EXISTS test_cat
+POSTHOOK: type: DROPCATALOG
+#### A masked pattern was here ####
+PREHOOK: type: CREATECATALOG
+PREHOOK: Output: catalog:test_cat
+#### A masked pattern was here ####
+POSTHOOK: type: CREATECATALOG
+POSTHOOK: Output: catalog:test_cat
+#### A masked pattern was here ####
+PREHOOK: query: SHOW CATALOGS
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS
+POSTHOOK: type: SHOWCATALOGS
+hive
+test_cat
+PREHOOK: query: SHOW CATALOGS LIKE 'test%'
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS LIKE 'test%'
+POSTHOOK: type: SHOWCATALOGS
+test_cat
+PREHOOK: query: SHOW CATALOGS LIKE 'test_'
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS LIKE 'test_'
+POSTHOOK: type: SHOWCATALOGS
+PREHOOK: query: SHOW CATALOGS LIKE 'test__'
+PREHOOK: type: SHOWCATALOGS
+POSTHOOK: query: SHOW CATALOGS LIKE 'test__'
+POSTHOOK: type: SHOWCATALOGS
+PREHOOK: query: DESC CATALOG test_cat
+PREHOOK: type: DESCCATALOG
+PREHOOK: Input: catalog:test_cat
+POSTHOOK: query: DESC CATALOG test_cat
+POSTHOOK: type: DESCCATALOG
+POSTHOOK: Input: catalog:test_cat
+#### A masked pattern was here ####
Review Comment:
I slightly think this should not be masked while it might not be trivial to
show it
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g:
##########
@@ -932,7 +932,7 @@ nonReserved
:
KW_ABORT | KW_ADD | KW_ADMIN | KW_AFTER | KW_ANALYZE | KW_ARCHIVE | KW_ASC
| KW_BEFORE | KW_BUCKET | KW_BUCKETS
| KW_CASCADE | KW_CBO | KW_CHANGE | KW_CHECK | KW_CLUSTER | KW_CLUSTERED |
KW_CLUSTERSTATUS | KW_COLLECTION | KW_COLUMNS
- | KW_COMMENT | KW_COMPACT | KW_COMPACTIONS | KW_COMPUTE | KW_CONCATENATE |
KW_CONTINUE | KW_COST | KW_DATA | KW_DAY
+ | KW_COMMENT | KW_COMPACT | KW_COMPACTIONS | KW_COMPUTE | KW_CONCATENATE |
KW_CONTINUE | KW_COST | KW_DATA | KW_DAY | KW_CATALOG | KW_CATALOGS
Review Comment:
I confirmed `CATALOG` is not a reserved word in SQL:2023 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
