soumyakanti3578 commented on code in PR #5196:
URL: https://github.com/apache/hive/pull/5196#discussion_r1940037089
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveRowIsDeletedPropagator.java:
##########
@@ -264,9 +263,10 @@ public RelNode visit(HiveJoin join, Context context) {
projectNames.add(ANY_INSERTED_COLUMN_NAME);
// Create input refs to derived expressions in project
- RelDataType boolIntType =
relBuilder.getTypeFactory().createSqlType(SqlTypeName.BOOLEAN);
- RexNode anyDeleted = rexBuilder.makeInputRef(boolIntType, projects.size()
- 2);
- RexNode anyInserted = rexBuilder.makeInputRef(boolIntType, projects.size()
- 1);
+ int anyDeletedIndex = projects.size() - 2;
+ int anyInsertedIndex = projects.size() - 1;
+ RexNode anyDeleted =
rexBuilder.makeInputRef(projects.get(anyDeletedIndex).getType(),
anyDeletedIndex);
+ RexNode anyInserted =
rexBuilder.makeInputRef(projects.get(anyInsertedIndex).getType(),
anyInsertedIndex);
Review Comment:
This doesn't seem necessary. I can remove it in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
