ryukobayashi commented on code in PR #5631:
URL: https://github.com/apache/hive/pull/5631#discussion_r1940545256


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java:
##########
@@ -277,6 +277,18 @@ public static HiveVectorIfStmtMode 
getHiveConfValue(HiveConf hiveConf) {
 
   private HiveVectorIfStmtMode hiveVectorIfStmtMode;
 
+  private Set<String> allowCustomUDFs;

Review Comment:
   Fixed.



##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java:
##########
@@ -277,6 +277,18 @@ public static HiveVectorIfStmtMode 
getHiveConfValue(HiveConf hiveConf) {
 
   private HiveVectorIfStmtMode hiveVectorIfStmtMode;
 
+  private Set<String> allowCustomUDFs;
+
+  private Set<String> getAllowCustomUDFs(HiveConf hiveConf) {

Review Comment:
   Fixed.



##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java:
##########
@@ -1447,7 +1460,7 @@ public static GenericUDF getGenericUDFForCast(TypeInfo 
castType) throws HiveExce
    * may be implemented in the future with an optimized VectorExpression.
    */
   public static boolean isNonVectorizedPathUDF(ExprNodeGenericFuncDesc expr,
-      VectorExpressionDescriptor.Mode mode) {
+      VectorExpressionDescriptor.Mode mode, Set<String> allowCustomUDFs) {

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to