deniskuzZ commented on code in PR #5614:
URL: https://github.com/apache/hive/pull/5614#discussion_r1948981279
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java:
##########
@@ -132,9 +132,11 @@ public TreeNode
visitBetweenCondition(PartitionFilterParser.BetweenConditionCont
@Override
public TreeNode visitInCondition(PartitionFilterParser.InConditionContext
ctx) {
- List<Object> values = visitConstantSeq(ctx.constantSeq());
boolean isPositive = ctx.NOT() == null;
- String keyName = (String) visit(ctx.key);
+ return buildInCondition(visitConstantSeq(ctx.constantSeq()), (String)
visit(ctx.key), isPositive);
+ }
+
+ private TreeNode buildInCondition(List<Object> values, String keyName,
boolean isPositive) {
Review Comment:
should we reverse the order of args, first `keyName` and then `values`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
