cnauroth commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1949623684
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
##########
@@ -133,14 +133,8 @@ public FileSystem getFs(Path f) throws MetaException {
/**
- * Hadoop File System reverse lookups paths with raw ip addresses The File
- * System URI always contains the canonical DNS name of the Namenode.
- * Subsequently, operations on paths with raw ip addresses cause an exception
- * since they don't match the file system URI.
Review Comment:
That is some very old code, going all the way back to
[HIVE-467](https://issues.apache.org/jira/browse/HIVE-467).
`TestWarehouseDnsPath` wasn't added until
[HIVE-24838](https://issues.apache.org/jira/browse/HIVE-24838), and I see the
discussion on the pull request about how the method doesn't really do what the
comments state.
I can't think of any reason why the logic wouldn't work for HDFS. Maybe at
the time of HIVE-467, the HDFS client had different behavior than it does
today, but I can't think of anything specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
