zabetak commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1950417092
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -79,13 +78,10 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
// so that the connection pool can retire the idle connection aggressively,
// this will make Metastore more scalable especially if there is a leader
in the warehouse.
if ("mutex".equals(poolName)) {
- int minimumIdle = Integer.valueOf(hdpConfig.get(HIKARI + ".minimumIdle",
"2"));
Review Comment:
This change seems unrelated to the purpose of the PR. Moreover, it seems to
remove the caching of small integers that happens when `valueOf` is used. Maybe
its better to leave things as is.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -55,6 +56,7 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
Properties properties = replacePrefix(
DataSourceProvider.getPrefixedProperties(hdpConfig, HIKARI));
long connectionTimeout = hdpConfig.getLong(CONNECTION_TIMEOUT_PROPERTY,
30000L);
+ long maxLifetime = hdpConfig.getLong(MAX_LIFETIME, 3600000L);
Review Comment:
I don't know if HIVE-25482 really wanted to set the default value to 1hr. I
get the impression that HIVE-25482 was created based on the misunderstanding
the the leak threshold was not configurable while in fact it was.
Since the default value of 1hr was always invalid it practically means that
if we leave it at zero we are not changing anything in the current behavior. I
guess the Hikaricp authors left the default to `0` because it is really
use-case specific.
Anyways, I don't feel strongly about zero, 10 minutes, or another value,
since when there is a problem we will most likely need to set this property
again anyways. I leave the final decision to you @okumin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
