deniskuzZ commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1954177009


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1825,6 +1825,36 @@ public enum ConfVars {
         "hive.metastore.properties.servlet.auth", "jwt",
         "Property-maps servlet authentication method (simple or jwt)."
     ),
+    ICEBERG_CATALOG_SERVLET_PATH("hive.metastore.catalog.servlet.path",

Review Comment:
   Is it supposed to be table-format agnostic RestCatalog, supporting both 
iceberg, external and Hive native tables; 
   I would expect It to expose via REST an interface to both Iceberg Catalog & 
HMS. 
   see https://www.databricks.com/product/unity-catalog
   [Unity Catalog](https://www.unitycatalog.io/) supports all 3 lakehouse table 
formats, but it also supports the major catalog interfaces across Iceberg Rest 
Catalog, Hive Metastore (HMS), and Unity Catalog.



##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1825,6 +1825,36 @@ public enum ConfVars {
         "hive.metastore.properties.servlet.auth", "jwt",
         "Property-maps servlet authentication method (simple or jwt)."
     ),
+    ICEBERG_CATALOG_SERVLET_PATH("hive.metastore.catalog.servlet.path",

Review Comment:
   Is it supposed to be table-format agnostic RestCatalog, supporting both 
iceberg, external and Hive native tables? 
   I would expect It to expose via REST an interface to both Iceberg Catalog & 
HMS. 
   see https://www.databricks.com/product/unity-catalog
   [Unity Catalog](https://www.unitycatalog.io/) supports all 3 lakehouse table 
formats, but it also supports the major catalog interfaces across Iceberg Rest 
Catalog, Hive Metastore (HMS), and Unity Catalog.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to