dengzhhu653 commented on code in PR #5578:
URL: https://github.com/apache/hive/pull/5578#discussion_r1961158718
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -576,12 +577,22 @@ public List<ColumnStatisticsObj>
getTableColumnStatistics(String dbName, String
/** {@inheritDoc} */
@Override
- public boolean deleteTableColumnStatistics(String dbName, String tableName,
String colName, String engine)
- throws TException {
- if (getTempTable(dbName, tableName) != null) {
- return deleteTempTableColumnStats(dbName, tableName, colName);
+ public boolean deleteColumnStatistics(DeleteColumnStatisticsRequest req)
throws TException {
+ String dbName = req.getDb_name();
+ String tableName = req.getTbl_name();
+ org.apache.hadoop.hive.metastore.api.Table table;
+ if ((table = getTempTable(dbName, tableName)) != null) {
+ List<String> colNames = req.getCol_names();
Review Comment:
`colNames` might be null or empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
