deniskuzZ commented on code in PR #5606: URL: https://github.com/apache/hive/pull/5606#discussion_r1961282361
########## standalone-metastore/metastore-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogServer.java: ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest; + +import java.io.IOException; +import java.lang.ref.Reference; +import java.lang.ref.SoftReference; +import java.util.Collections; +import java.util.Map; +import java.util.TreeMap; +import javax.servlet.http.HttpServlet; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.metastore.SecureServletCaller; +import org.apache.hadoop.hive.metastore.ServletSecurity; +import org.apache.hadoop.hive.metastore.conf.MetastoreConf; +import org.apache.iceberg.HiveCachingCatalog; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.hive.HiveCatalog; +import org.eclipse.jetty.server.ConnectionFactory; +import org.eclipse.jetty.server.Connector; +import org.eclipse.jetty.server.HttpConfiguration; +import org.eclipse.jetty.server.HttpConnectionFactory; +import org.eclipse.jetty.server.Server; +import org.eclipse.jetty.server.ServerConnector; +import org.eclipse.jetty.server.handler.gzip.GzipHandler; +import org.eclipse.jetty.servlet.ServletContextHandler; +import org.eclipse.jetty.servlet.ServletHolder; +import org.eclipse.jetty.util.ssl.SslContextFactory; +import org.eclipse.jetty.util.thread.QueuedThreadPool; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class HMSCatalogServer { + private static final String CACHE_EXPIRY = "hive.metastore.catalog.cache.expiry"; + private static final String JETTY_THREADPOOL_MIN = "hive.metastore.catalog.jetty.threadpool.min"; + private static final String JETTY_THREADPOOL_MAX = "hive.metastore.catalog.jetty.threadpool.max"; + private static final String JETTY_THREADPOOL_IDLE = "hive.metastore.catalog.jetty.threadpool.idle"; + private static final Logger LOG = LoggerFactory.getLogger(HMSCatalogServer.class); + private static Reference<Catalog> catalogRef; + + static Catalog getLastCatalog() { + return catalogRef != null ? catalogRef.get() : null; + } + + private HMSCatalogServer() { + // nothing + } + + public static HttpServlet createServlet(SecureServletCaller security, Catalog catalog) throws IOException { + return new HMSCatalogServlet(security, new HMSCatalogAdapter(catalog)); + } + + public static Catalog createCatalog(Configuration configuration) { + final String curi = configuration.get(MetastoreConf.ConfVars.THRIFT_URIS.getVarname()); + final String cwarehouse = configuration.get(MetastoreConf.ConfVars.WAREHOUSE.getVarname()); + final String cextwarehouse = configuration.get(MetastoreConf.ConfVars.WAREHOUSE_EXTERNAL.getVarname()); + MetastoreConf.setVar(configuration, MetastoreConf.ConfVars.THRIFT_URIS, ""); + MetastoreConf.setVar(configuration, MetastoreConf.ConfVars.HMS_HANDLER_CREATE, "newHMSRetryingLocalHandler"); + final HiveCatalog catalog = new org.apache.iceberg.hive.HiveCatalog(); + catalog.setConf(configuration); + Map<String, String> properties = new TreeMap<>(); + if (curi != null) { + properties.put("uri", curi); + } + if (cwarehouse != null) { + properties.put("warehouse", cwarehouse); + } + if (cextwarehouse != null) { + properties.put("external-warehouse", cextwarehouse); + } + catalog.initialize("hive", properties); + long expiry = configuration.getLong(CACHE_EXPIRY, 60_000L); + return expiry > 0? HiveCachingCatalog.wrap(catalog, expiry) : catalog; + } + + public static HttpServlet createServlet(Configuration configuration, Catalog catalog) throws IOException { + String auth = MetastoreConf.getVar(configuration, MetastoreConf.ConfVars.ICEBERG_CATALOG_SERVLET_AUTH); + boolean jwt = "jwt".equalsIgnoreCase(auth); + SecureServletCaller security = new ServletSecurity(configuration, jwt); + Catalog actualCatalog = catalog; + if (actualCatalog == null) { + actualCatalog = createCatalog(configuration); + actualCatalog.initialize("hive", Collections.emptyMap()); + } + catalogRef = new SoftReference<>(actualCatalog); + return createServlet(security, actualCatalog); + } + + /** + * Convenience method to start a http server that only serves this servlet. + * @param conf the configuration + * @param catalog the catalog instance to serve + * @return the server instance + * @throws Exception if servlet initialization fails + */ + public static Server startServer(Configuration conf, HiveCatalog catalog) throws Exception { + int port = MetastoreConf.getIntVar(conf, MetastoreConf.ConfVars.ICEBERG_CATALOG_SERVLET_PORT); + if (port < 0) { + return null; + } + final HttpServlet servlet = createServlet(conf, catalog); + ServletContextHandler context = new ServletContextHandler(ServletContextHandler.NO_SESSIONS); + context.setContextPath("/"); + ServletHolder servletHolder = new ServletHolder(servlet); + servletHolder.setInitParameter("javax.ws.rs.Application", "ServiceListPublic"); + final String cli = MetastoreConf.getVar(conf, MetastoreConf.ConfVars.ICEBERG_CATALOG_SERVLET_PATH); + context.addServlet(servletHolder, "/" + cli + "/*"); + context.setVirtualHosts(null); + context.setGzipHandler(new GzipHandler()); + + final Server httpServer = createHttpServer(conf, port); + httpServer.setHandler(context); + LOG.info("Starting HMS REST Catalog Server with context path:/{}/ on port:{}", cli, port); + httpServer.start(); + return httpServer; + } + + private static Server createHttpServer(Configuration conf, int port) throws IOException { + final int maxThreads = conf.getInt(JETTY_THREADPOOL_MAX, 256); + final int minThreads = conf.getInt(JETTY_THREADPOOL_MIN, 8); + final int idleTimeout = conf.getInt(JETTY_THREADPOOL_IDLE, 60_000); + final QueuedThreadPool threadPool = new QueuedThreadPool(maxThreads, minThreads, idleTimeout); + final Server httpServer = new Server(threadPool); + final SslContextFactory sslContextFactory = ServletSecurity.createSslContextFactory(conf); + final ServerConnector connector = new ServerConnector(httpServer, sslContextFactory); + connector.setPort(port); + connector.setReuseAddress(true); + httpServer.setConnectors(new Connector[] {connector}); + for (ConnectionFactory factory : connector.getConnectionFactories()) { + if (factory instanceof HttpConnectionFactory) { + HttpConnectionFactory httpFactory = (HttpConnectionFactory) factory; + HttpConfiguration httpConf = httpFactory.getHttpConfiguration(); + httpConf.setSendServerVersion(false); + httpConf.setSendXPoweredBy(false); + } + } + return httpServer; + } + + + /** + * Convenience method to start a http server that only serves this servlet. + * <p>This one is looked up through reflection to start from HMS.</p> + * @param conf the configuration + * @return the server instance + * @throws Exception if servlet initialization fails + */ + public static Server startServer(Configuration conf) throws Exception { + return startServer(conf, null); Review Comment: Jetty (like Tomcat) is a servlet container that can host multiple servlets within the same instance. You don’t need a separate Jetty instance for each servlet because Jetty is designed to manage multiple servlets efficiently in a single process. Each Jetty instance runs as a separate JVM process, consuming system resources (CPU, memory, ports, threads). If you start a separate Jetty server for each servlet, you waste resources running multiple JVMs, which can cause unnecessary overhead. Using a single Jetty instance allows efficient request routing, shared memory, and optimized resource management. A better approach is to configure different servlets with different context paths inside a single Jetty instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
