deniskuzZ commented on code in PR #5645:
URL: https://github.com/apache/hive/pull/5645#discussion_r1965438664
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:
##########
@@ -598,7 +598,26 @@ public static Map<Integer, List<ExprNodeGenericFuncDesc>>
getFullPartitionSpecs(
for (int i = 0; i < partSpecTree.getChildCount(); ++i) {
CommonTree partSpecSingleKey = (CommonTree) partSpecTree.getChild(i);
assert (partSpecSingleKey.getType() == HiveParser.TOK_PARTVAL);
- String key =
stripIdentifierQuotes(partSpecSingleKey.getChild(0).getText()).toLowerCase();
+ String columnName;
+ String key;
+ if (partSpecSingleKey.getChild(0).getType() ==
HiveParser.TOK_FUNCTION) {
+ int childCount = partSpecSingleKey.getChild(0).getChildCount();
+ if (childCount == 2) { // Case with type and key
Review Comment:
could we create local var for `partSpecSingleKey.getChild(0)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
