deniskuzZ commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1965546754
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -119,11 +122,15 @@ public class HiveMetaStore extends ThriftHiveMetastore {
private static ZooKeeperHiveHelper zooKeeperHelper = null;
private static String msHost = null;
private static ThriftServer thriftServer;
- private static Server propertyServer = null;
+ private static Server servletServer = null;
public static Server getPropertyServer() {
- return propertyServer;
+ return servletServer;
+ }
+
+ public static Server getIcebergServer() {
Review Comment:
can we keep jus 1 getter - `getServlet[Server/Container]()` or something
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -119,11 +122,15 @@ public class HiveMetaStore extends ThriftHiveMetastore {
private static ZooKeeperHiveHelper zooKeeperHelper = null;
private static String msHost = null;
private static ThriftServer thriftServer;
- private static Server propertyServer = null;
+ private static Server servletServer = null;
public static Server getPropertyServer() {
- return propertyServer;
+ return servletServer;
+ }
+
+ public static Server getIcebergServer() {
Review Comment:
can we keep jus 1 getter - `getServlet[Server/Container]` or something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
