deniskuzZ commented on code in PR #5645:
URL: https://github.com/apache/hive/pull/5645#discussion_r1965964431
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -1137,11 +1140,7 @@ public void
preDropPartitions(org.apache.hadoop.hive.metastore.api.Table hmsTabl
ExprNodeDesc exprNodeDesc = SerializationUtilities
.deserializeObjectWithTypeInformation(partExpr.getRight(), true);
SearchArgument sarg = ConvertAstToSearchArg.create(conf,
(ExprNodeGenericFuncDesc) exprNodeDesc);
- for (PredicateLeaf leaf : sarg.getLeaves()) {
- if (leaf.getColumnName() != null &&
!partitionFieldMap.containsKey(leaf.getColumnName())) {
- throw new UnsupportedOperationException("Drop Partition not
supported on Transformed Columns");
- }
- }
+ validatePartitionSpec(sarg, icebergTbl);
Review Comment:
@ayushtkn, can we drop `partitionFieldMap` it's no longer used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
