deniskuzZ commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1967585611
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -730,11 +768,44 @@ public static void startMetaStore(int port,
HadoopThriftAuthBridge bridge,
throw e;
}
}
- // optionally create and start the property server and servlet
- propertyServer = PropertyServlet.startServer(conf);
-
+ // optionally create and start the property and Iceberg REST server
+ ServletServerBuilder.Descriptor properties =
PropertyServlet.createServlet(conf);
+ ServletServerBuilder.Descriptor catalog = createIcebergServlet(conf);
+ ServletServerBuilder builder = new ServletServerBuilder(conf);
+ builder.addServlet(properties);
Review Comment:
minor: could we create and add servlet close to each other
````
ServletServerBuilder.Descriptor properties =
PropertyServlet.createServlet(conf);
builder.addServlet(properties);
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
