mszurap opened a new pull request, #5664: URL: https://github.com/apache/hive/pull/5664
### What changes were proposed in this pull request? Hive should reject requests for altering table statistics which try to set numerical values to non-numeric values. Currently these are numFiles, numPartitions, totalSize, rawDataSize, numFilesErasureCoded. Worth to note that currently the "totalSize", "numFiles" and "numFilesErasureCoded" cannot be directly updated with an alter statement, still the new code verifies these and rejects the query in case the value is not a number (including an empty string). ### Why are the changes needed? Non-numeric values in these table properties can cause other application failures, see the description in [HIVE-28124](https://issues.apache.org/jira/browse/HIVE-28124). ### Does this PR introduce _any_ user-facing change? Queries like "alter table stat_test set TBLPROPERTIES('rawDataSize'='NaN')" are now failing with "SemanticException AlterTable rawDataSize failed with value NaN" ### Is the change a dependency upgrade? No ### How was this patch tested? qtests added (both positive and negative), ran the tests successfully with "TestCliDriver". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
