deniskuzZ commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1976666504
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ServletSecurity.java:
##########
@@ -193,35 +274,40 @@ static void loginServerPincipal(Configuration conf)
throws IOException {
LOG.info("Security is not enabled. Not logging in via keytab");
}
}
+
/**
* Creates an SSL context factory if configuration states so.
* @param conf the configuration
* @return null if no ssl in config, an instance otherwise
* @throws IOException if getting password fails
*/
- static SslContextFactory createSslContextFactory(Configuration conf) throws
IOException {
+ public static SslContextFactory createSslContextFactory(Configuration conf)
throws IOException {
Review Comment:
should it be public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
