abstractdog commented on code in PR #5666:
URL: https://github.com/apache/hive/pull/5666#discussion_r1977132801
##########
ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/IcebergRepository.java:
##########
@@ -176,4 +187,9 @@ private void prepareConfForWrite() {
SessionStateUtil.addCommitInfo(SessionState.getSessionConf(),
tableDesc.getTableName(), jobId, 1,
Maps.fromProperties(tableDesc.getProperties()));
}
+
+ private void expireSnapshots() {
+ storageHandler.executeOperation(table, new
AlterTableExecuteSpec<>(EXPIRE_SNAPSHOT,
+ new AlterTableExecuteSpec.ExpireSnapshotsSpec(10)));
Review Comment:
thanks @ayushtkn for taking a look!
good point, I'm not familiar with EXPIRE SNAPSHOT functionality detail, so
this is more like a DRAFT, let me consider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
