Indhumathi27 commented on code in PR #5649: URL: https://github.com/apache/hive/pull/5649#discussion_r1979398244
########## service/src/java/org/apache/hive/service/cli/CLIService.java: ########## @@ -126,13 +126,14 @@ public synchronized void init(HiveConf hiveConf) { } private void applyAuthorizationConfigPolicy(HiveConf newHiveConf) throws HiveException, - MetaException { + MetaException, IOException { // authorization setup using SessionState should be revisited eventually, as // authorization and authentication are not session specific settings SessionState ss = new SessionState(newHiveConf); ss.setIsHiveServerQuery(true); SessionState.start(ss); ss.applyAuthorizationPolicy(); + ss.close(); Review Comment: Some test scenarios like PrivilegeSynchronizer, Tez session ACL setup fails if the session is closed after applyAuthorizationPolicy. Hence added a shutdownhook to close this session -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org