ngsg commented on PR #3998: URL: https://github.com/apache/hive/pull/3998#issuecomment-2699754753
I have updated the missing qtest output and addressed some issues reported by SonarCloud. However, I haven't implemented "usage of generic wildcard type" in OperatorGraph.java as suggested because resolving this issue would likely require either extensive refactoring or double unchecked type casting, which is another type of code smell. (e.g. `return (DagGraph<Operator<OperatorDesc>, OpEdge>) (DagGraph<?, OpEdge>) dagGraph;`) If you have any alternative suggestions, I would appreciate your input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
