kasakrisz commented on code in PR #5663:
URL: https://github.com/apache/hive/pull/5663#discussion_r1983096410
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java:
##########
@@ -366,8 +369,7 @@ public static RexNode handleExplicitCast(GenericUDF udf,
RelDataType returnType,
* It will be transformed into:
* CASE WHEN =(x + y, 1) THEN 'fee' WHEN =(x + y, 2) THEN 'fie' ELSE null END
*/
- public static List<RexNode> rewriteCaseChildren(String funcText,
List<RexNode> childRexNodeLst,
- RexBuilder rexBuilder) throws SemanticException {
+ public List<RexNode> rewriteCaseChildren(String funcText, List<RexNode>
childRexNodeLst) throws SemanticException {
List<RexNode> newChildRexNodeLst = new ArrayList<>();
if (FunctionRegistry.getNormalizedFunctionName(funcText).equals("case")) {
Review Comment:
Having one UDF to handle case expressions is a good idea.
Submitted an alternative solution #5681
Let's see how it goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
