dengzhhu653 commented on code in PR #5661:
URL: https://github.com/apache/hive/pull/5661#discussion_r1984382901


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -677,10 +656,6 @@ public boolean isActiveTransaction() {
    */
   @Override
   public void rollbackTransaction() {
-    if (openTrasactionCalls < 1) {

Review Comment:
   This original can only fix the leak on primary pool, the secondary pool can 
still have such issue, 
https://github.com/dengzhhu653/hive/commit/7b4a66cf030e8570214341424bab258520abe919
 can reproduce the problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to