KiranVelumuri commented on code in PR #5525:
URL: https://github.com/apache/hive/pull/5525#discussion_r1984465270
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mysql.java:
##########
@@ -67,9 +67,9 @@ public String getInitialJdbcUrl(String hostAddress) {
@Override
public boolean isContainerReady(ProcessResults pr) {
- Pattern pat = Pattern.compile("ready for connections");
+ Pattern pat = Pattern.compile("mysqld.*ready for connections.*port.*3306");
Review Comment:
Logs for mysql:5.7.37:
```
2025-01-07 10:55:06 2025-01-07T05:25:06.712678Z 0 [Note] mysqld: ready for
connections.
2025-01-07 10:55:06 Version: '5.7.37' socket: '/var/run/mysqld/mysqld.sock'
port: 0 MySQL Community Server (GPL)
2025-01-07 10:55:07 2025-01-07 05:25:07+00:00 [Note] [Entrypoint]: Temporary
server started.
2025-01-07 10:55:07 Warning: Unable to load
'/usr/share/zoneinfo/iso3166.tab' as time zone. Skipping it.
2025-01-07 10:55:07 Warning: Unable to load
'/usr/share/zoneinfo/leap-seconds.list' as time zone. Skipping it.
2025-01-07 10:55:08 Warning: Unable to load '/usr/share/zoneinfo/zone.tab'
as time zone. Skipping it.
2025-01-07 10:55:08 Warning: Unable to load
'/usr/share/zoneinfo/zone1970.tab' as time zone. Skipping it.
2025-01-07 10:55:08
2025-01-07 10:55:08 2025-01-07 05:25:08+00:00 [Note] [Entrypoint]: Stopping
temporary server
.
.
.
2025-01-07 10:55:11 2025-01-07T05:25:11.068948Z 0 [Note] mysqld: ready for
connections.
2025-01-07 10:55:11 Version: '5.7.37' socket: '/var/run/mysqld/mysqld.sock'
port: 3306 MySQL Community Server (GPL)
```
Logs for 8.4.3:
```
2025-01-07 10:53:49 2025-01-07T05:23:49.277980Z 0 [System] [MY-010931]
[Server] /usr/sbin/mysqld: ready for connections. Version: '8.4.3' socket:
'/var/run/mysqld/mysqld.sock' port: 0 MySQL Community Server - GPL.
2025-01-07 10:53:49 2025-01-07T05:23:49.278850Z 0 [System] [MY-011323]
[Server] X Plugin ready for connections. Socket: /var/run/mysqld/mysqlx.sock
2025-01-07 10:53:49 2025-01-07 05:23:49+00:00 [Note] [Entrypoint]: Temporary
server started.
2025-01-07 10:53:49 '/var/lib/mysql/mysql.sock' ->
'/var/run/mysqld/mysqld.sock'
2025-01-07 10:53:49 Warning: Unable to load
'/usr/share/zoneinfo/iso3166.tab' as time zone. Skipping it.
2025-01-07 10:53:49 Warning: Unable to load
'/usr/share/zoneinfo/leap-seconds.list' as time zone. Skipping it.
2025-01-07 10:53:49 Warning: Unable to load
'/usr/share/zoneinfo/leapseconds' as time zone. Skipping it.
2025-01-07 10:53:50 Warning: Unable to load '/usr/share/zoneinfo/tzdata.zi'
as time zone. Skipping it.
2025-01-07 10:53:50 Warning: Unable to load '/usr/share/zoneinfo/zone.tab'
as time zone. Skipping it.
2025-01-07 10:53:50 Warning: Unable to load
'/usr/share/zoneinfo/zone1970.tab' as time zone. Skipping it.
2025-01-07 10:53:50
2025-01-07 10:53:50 2025-01-07 05:23:50+00:00 [Note] [Entrypoint]: Stopping
temporary server
.
.
.
2025-01-07 10:53:52 2025-01-07T05:23:52.806441Z 0 [System] [MY-010931]
[Server] /usr/sbin/mysqld: ready for connections. Version: '8.4.3' socket:
'/var/run/mysqld/mysqld.sock' port: 3306 MySQL Community Server - GPL.
2025-01-07 10:53:52 2025-01-07T05:23:52.807530Z 0 [System] [MY-011323]
[Server] X Plugin ready for connections. Bind-address: '::' port: 33060,
socket: /var/run/mysqld/mysqlx.sock
```
Earlier the search pattern ```ready for connections``` occurred twice, and
now 4 times. So, I changed the regex pattern instead to handle better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
