abstractdog commented on code in PR #5687:
URL: https://github.com/apache/hive/pull/5687#discussion_r1986957186
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -409,8 +411,12 @@ public void
preAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable, E
context.getProperties().get(OLD_TABLE_NAME)).toString());
}
if (commitLock == null) {
- commitLock = new MetastoreLock(conf, new CachedClientPool(conf,
Maps.fromProperties(catalogProperties)),
- catalogProperties.getProperty(Catalogs.NAME), hmsTable.getDbName(),
hmsTable.getTableName());
+ if (HiveTableOperations.hiveLockEnabled(null, conf)) {
Review Comment:
what is interesting is that I can almost only see this whole
hiveLockEnabled(...) thing used in testing scenarios, which applies to my case
as well, see screenshot
<img width="868" alt="Screenshot 2025-03-10 at 10 40 58"
src="https://github.com/user-attachments/assets/8947c5c2-827e-4e72-a8be-32b03574a719";
/>
this makes me think that if I want to make my query history PR snapshot work
then
a) I have to override the locking behavior and bypass it in case of tests by
extending the meta hook instead and use a testing one
b) or make it work with metastore locking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
