abstractdog commented on code in PR #5666:
URL: https://github.com/apache/hive/pull/5666#discussion_r1988764662
##########
ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/IcebergRepository.java:
##########
@@ -176,4 +193,13 @@ private void prepareConfForWrite() {
SessionStateUtil.addCommitInfo(SessionState.getSessionConf(),
tableDesc.getTableName(), jobId, 1,
Maps.fromProperties(tableDesc.getProperties()));
}
+
+ private void expireSnapshots() {
Review Comment:
yeah, theoretically, handling them in a centralized place in metastore
instead of multiple HS2s looks better from system design point of view
however, it needs a new service to be implemented, let me check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
