abstractdog commented on code in PR #5691:
URL: https://github.com/apache/hive/pull/5691#discussion_r1993116636
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/NonNativeAcidMaterializedViewASTBuilder.java:
##########
@@ -50,12 +50,7 @@ public void appendDeleteSelectNodes(ASTNode selectNode,
String tableName) {
for (int i = 0; i < selectNode.getChildCount(); ++i) {
ASTNode selectExpr = (ASTNode) selectNode.getChild(i);
- ASTNode expression = (ASTNode) selectExpr.getChild(0);
- if (expression.getType() == HiveParser.DOT &&
- expression.getChildCount() == 2 &&
- expression.getChild(0).getType() == HiveParser.TOK_TABLE_OR_COL) {
- selectedColumns.add(expression.getChild(1).getText());
- }
+ selectedColumns.add(selectExpr.getChild(selectExpr.getChildCount() -
1).getText());
Review Comment:
does this fix the same problem for types other than varchar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
