deniskuzZ commented on code in PR #5648: URL: https://github.com/apache/hive/pull/5648#discussion_r2002699680
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ########## @@ -491,23 +481,33 @@ public void appendFiles(org.apache.hadoop.hive.metastore.api.Table table, URI fr @Override public Map<String, String> getBasicStatistics(Partish partish) { + return getBasicStatistics(partish, false); + } + + @SuppressWarnings("checkstyle:CyclomaticComplexity") + private Map<String, String> getBasicStatistics(Partish partish, boolean quickStats) { Review Comment: `quickStats` is a part of stats that could be effortlessly computed: - NUM_FILES, - TOTAL_SIZE - NUM_ERASURE_CODED_FILES see `MetaStoreServerUtils.populateQuickStats` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org