deniskuzZ commented on code in PR #5699:
URL: https://github.com/apache/hive/pull/5699#discussion_r2003259204
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreTServerSocket.java:
##########
@@ -29,8 +32,32 @@
* accepted sockets.
*
*/
-public class TServerSocketKeepAlive extends TServerSocket {
- public TServerSocketKeepAlive(TServerSocket serverSocket) throws
TTransportException {
+public class MetastoreTServerSocket extends TServerSocket {
+ private final Configuration configuration;
+
+ public MetastoreTServerSocket(TServerSocket serverSocket,
+ Configuration conf) throws TTransportException {
super(serverSocket.getServerSocket());
+ this.configuration = Objects.requireNonNull(conf);
+ }
+
+ @Override
+ public TSocket accept() throws TTransportException {
+ TSocket ts = super.accept();
+ boolean keepAlive = MetastoreConf.getBoolVar(configuration,
MetastoreConf.ConfVars.TCP_KEEP_ALIVE);
+ if (keepAlive) {
+ try {
+ ts.getSocket().setKeepAlive(true);
+ } catch (SocketException e) {
+ throw new TTransportException(e);
+ }
+ }
+ // for testing purpose, get the maxThriftMessageSize from the
configuration for every new connection
Review Comment:
we shouldn't use suboptimal design just for the sake of tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
