kasakrisz commented on code in PR #5702:
URL: https://github.com/apache/hive/pull/5702#discussion_r2004979147
##########
ql/src/test/queries/clientpositive/udf_to_string.q:
##########
@@ -1,21 +1,34 @@
---! qt:dataset:src
+--! qt:dataset:alltypesorc
set hive.fetch.task.conversion=more;
-- Conversion of main primitive types to String type:
-SELECT CAST(NULL AS STRING) FROM src tablesample (1 rows);
+SELECT CAST(NULL AS STRING) FROM alltypesorc tablesample (1 rows);
-SELECT CAST(TRUE AS STRING) FROM src tablesample (1 rows);
+SELECT CAST(TRUE AS STRING) FROM alltypesorc tablesample (1 rows);
-SELECT CAST(CAST(1 AS TINYINT) AS STRING) FROM src tablesample (1 rows);
-SELECT CAST(CAST(-18 AS SMALLINT) AS STRING) FROM src tablesample (1 rows);
-SELECT CAST(-129 AS STRING) FROM src tablesample (1 rows);
-SELECT CAST(CAST(-1025 AS BIGINT) AS STRING) FROM src tablesample (1 rows);
+SELECT CAST(CAST(1 AS TINYINT) AS STRING) FROM alltypesorc tablesample (1
rows);
+SELECT CAST(CAST(-18 AS SMALLINT) AS STRING) FROM alltypesorc tablesample (1
rows);
+SELECT CAST(-129 AS STRING) FROM alltypesorc tablesample (1 rows);
+SELECT CAST(CAST(-1025 AS BIGINT) AS STRING) FROM alltypesorc tablesample (1
rows);
-SELECT CAST(CAST(-3.14 AS DOUBLE) AS STRING) FROM src tablesample (1 rows);
-SELECT CAST(CAST(-3.14 AS FLOAT) AS STRING) FROM src tablesample (1 rows);
-SELECT CAST(CAST(-3.14 AS DECIMAL(3,2)) AS STRING) FROM src tablesample (1
rows);
+SELECT CAST(CAST(-3.14 AS DOUBLE) AS STRING) FROM alltypesorc tablesample (1
rows);
+SELECT CAST(CAST(-3.14 AS FLOAT) AS STRING) FROM alltypesorc tablesample (1
rows);
+SELECT CAST(CAST(-3.14 AS DECIMAL(3,2)) AS STRING) FROM alltypesorc
tablesample (1 rows);
-SELECT CAST('Foo' AS STRING) FROM src tablesample (1 rows);
+SELECT CAST('Foo' AS STRING) FROM alltypesorc tablesample (1 rows);
Review Comment:
Does the from clause relevant in these statements? It seem that we are
casting constants.
Example:
```
SELECT CAST(CAST(-3.14 AS DOUBLE) AS STRING);
```
should also test `GenericUDFToString`.
Could you please confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
