dengzhhu653 commented on code in PR #5661: URL: https://github.com/apache/hive/pull/5661#discussion_r2009460657
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java: ########## @@ -90,7 +94,42 @@ public DataSource create(Configuration hdpConfig, int maxPoolSize) throws SQLExc config.addDataSourceProperty(kv.getKey(), kv.getValue()); } - return new HikariDataSource(initMetrics(config)); + return new HikariDataSource(initMetrics(config)) { + @Override + public Connection getConnection() throws SQLException { Review Comment: since [HIVE-28839](https://issues.apache.org/jira/browse/HIVE-28839) was created to address the independent secondary connection leak, I reverted the changes on the data source -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org