Indhumathi27 commented on PR #5708: URL: https://github.com/apache/hive/pull/5708#issuecomment-2747030195
> We have two more use cases of `ResourceDownloader`. > > ### AsyncTaskCreateUdfFile > [The class uses ResourceDownloader to download UDF files to upload them as one of LLAP artiracts](https://github.com/apache/hive/blob/3b562f7fefbb34ce6c191d23325d9f0c882271b2/llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/AsyncTaskCreateUdfFile.java#L98). The directory is [explicitly created outside ResourceDownloader](https://github.com/apache/hive/blob/3b562f7fefbb34ce6c191d23325d9f0c882271b2/llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/LlapTarComponentGatherer.java#L69-L79). This patch will unlikely cause a new issue. > > ### FunctionLocalizer > [The class uses ResourceDownloader to download UDFs](https://github.com/apache/hive/blob/3b562f7fefbb34ce6c191d23325d9f0c882271b2/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java#L93). It is not created unless `ResourceDownloader#downloadResource` is used. > > I slightly think we may not need to "ensureDirectory" on creating ResourceDownloader. That's because `resourceDir` is used only in `downloadResource` and the method ensures the same or more. Thanks @okumin for the review. You are right. It is not required to ensure directories at the start of the session as well, as ResourceDownloader#downloadResource will ensure it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
