kasakrisz commented on code in PR #5691:
URL: https://github.com/apache/hive/pull/5691#discussion_r2011812523
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##########
@@ -102,6 +103,7 @@ public MetastoreLock(Configuration conf,
ClientPool<IMetaStoreClient, TException
this.fullName = catalogName + "." + databaseName + "." + tableName;
this.databaseName = databaseName;
this.tableName = tableName;
+ this.conf = conf;
Review Comment:
Setting the TxnId of the Acid txn is not necessary and it would require
Iceberg code change too.
I prepared a follow-up patch reverting the locking related changes and
implement another approach: #5716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
