okumin commented on code in PR #5707: URL: https://github.com/apache/hive/pull/5707#discussion_r2012347148
########## ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java: ########## @@ -182,6 +187,30 @@ public static ReduceWork createReduceWork( return reduceWork; } + private static boolean hasBucketMapJoin(Operator<? extends OperatorDesc> operator) { + if (operator == null) { + return false; + } + + // Iterate over child operators + for (Operator<? extends OperatorDesc> childOp : operator.getChildOperators()) { + // Check if this is a MapJoinOperator and is a Bucket Map Join + if (childOp instanceof MapJoinOperator) { + MapJoinOperator mjOp = (MapJoinOperator) childOp; + if (mjOp.getConf().isBucketMapJoin()) { + return true; // Found BMJ, no need to check further + } + } + + // Recursively check children + if (hasBucketMapJoin(childOp)) { + return true; + } Review Comment: Do we have to check it recursively? ``` TS -> BMJ ^ | TS -> RS1 -> RS2 --| ``` I currently guess we can enable auto reducer parallelism for RS1. So, we may have to check BMJ's direct parent, i.e., RS2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org